Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource list item thumbnails aren't showing in Firefox & IE Edge #483

Closed
SMaxOwok opened this issue Aug 1, 2017 · 4 comments
Closed

Resource list item thumbnails aren't showing in Firefox & IE Edge #483

SMaxOwok opened this issue Aug 1, 2017 · 4 comments
Assignees
@naomiyaki @blnkt @SMaxOwok
Labels
Type: Bug Issue represents a defect or error in Manifold.
Projects
Manifold v0.4.0
Milestone
v0.4.0

Comments

@SMaxOwok
Copy link
Member

SMaxOwok commented Aug 1, 2017 •
edited

Only in Firefox

screen shot 2017-08-01 at 1 35 13 pm

screen shot 2017-08-01 at 1 35 26 pm
@SMaxOwok SMaxOwok added the Type: Bug Issue represents a defect or error in Manifold. label Aug 1, 2017
@SMaxOwok
Copy link
Member Author

SMaxOwok commented Aug 4, 2017

screen shot 2017-08-04 at 2 12 21 pm

Has something to do with how FF interprets this padding.

@SMaxOwok
Copy link
Member Author

SMaxOwok commented Aug 7, 2017 •
edited

https://drafts.csswg.org/css-flexbox/#item-margins

Seems like a fix is to add a height to the flex container. https://bugzilla.mozilla.org/show_bug.cgi?id=958714#c5

@zdavis zdavis added this to the v0.3 milestone Oct 2, 2017
@naomiyaki naomiyaki added Status: In Progress Issue is being actively worked on or has an open pull request associated with it. Status: Blocked The issue is currently blocked and is not actionable. and removed Status: In Progress Issue is being actively worked on or has an open pull request associated with it. labels Oct 2, 2017
@naomiyaki
Copy link
Contributor

This is blocked by #630

@zdavis
Copy link
Member

zdavis commented Oct 12, 2017

#630 has been resolved.

@zdavis zdavis removed the Status: Blocked The issue is currently blocked and is not actionable. label Oct 12, 2017
@zdavis zdavis modified the milestones: v0.3, v0.4 Oct 16, 2017
@zdavis zdavis added this to Planned in Manifold v0.4.0 Oct 16, 2017
@blnkt blnkt changed the title Resource list item thumbnails aren't showing in FF Resource list item thumbnails aren't showing in Firefox & IE Edge Dec 20, 2017
blnkt pushed a commit that referenced this issue Dec 20, 2017
[B] Fix resource list icon issue in FF & IE Edge
1a54bb8 
Resolves #483
@zdavis zdavis closed this as completed in 620112a Dec 29, 2017
@zdavis zdavis moved this from Backlog to Completed in Manifold v0.4.0 Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naomiyaki naomiyaki

@blnkt blnkt

@SMaxOwok SMaxOwok

Labels
Type: Bug Issue represents a defect or error in Manifold.
Projects
No open projects
Manifold v0.4.0
Completed
Milestone
v0.4.0
Development

No branches or pull requests
4 participants
@zdavis @naomiyaki @blnkt @SMaxOwok