Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manimpango work with MarkupText #1

Merged
merged 3 commits into from
Dec 24, 2020

Conversation

PhilippImhof
Copy link
Member

Added MarkupUtils class (for separation) with static text2svg method in order to be able to use manimpango with the new MarkupText class -- as discussed on Discord

manimpango/cmanimpango.pyx Outdated Show resolved Hide resolved
manimpango/cmanimpango.pyx Outdated Show resolved Hide resolved
Co-authored-by: Naveen M K <naveen@syrusdark.website>
@naveen521kk
Copy link
Member

Let checks pass and I will merge and release it.

Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naveen521kk naveen521kk merged commit 4eaa649 into ManimCommunity:main Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants