Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split into multiple modules and Files #31

Merged
merged 3 commits into from
Feb 28, 2021
Merged

Split into multiple modules and Files #31

merged 3 commits into from
Feb 28, 2021

Conversation

naveen521kk
Copy link
Member

it's too long and clumsy to maintain currently.
No API changes, just for the sake of maintenance moved code around.

it's too long and clumsy to maintain currently
This was referenced Feb 27, 2021
@naveen521kk
Copy link
Member Author

@PhilippImhof any comments?

@PhilippImhof
Copy link
Member

Haha...good timing. I was just scrolling through the changes :)

Copy link
Member

@PhilippImhof PhilippImhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@naveen521kk naveen521kk merged commit 326da7f into main Feb 28, 2021
@naveen521kk naveen521kk deleted the clean branch February 28, 2021 15:39
@naveen521kk naveen521kk added this to the v0.2.5 milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants