-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add awesome-manim feed to manim-website #73
Conversation
@naveen521kk @behackl how should we implement the caroussel? The most recent verdict was:
Video selectionThe thumbnails should ideally be attractive. We can use these for now:
We can later run a poll in the server and vote on the videos to be featured on the home page. Wdyt? |
src/pages/awesome.js
Outdated
import NavBar from "../components/navbar.js"; | ||
import {Footer} from "../components/footer.js"; | ||
import {default as InfiniteScroll} from "infinite-scroll"; | ||
import $ from "jquery"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I would like to write this in pure react rather than importing jquery like this. I think using a different library rather than infinte-scroll is better and I'll have a look at this a bit later.
I have added the YouTube carousel. Requires attention |
This works now |
…aded on YouTube Carousel
Should we add a disclaimer at the top that the feed features videos made with both Manim CE and 3b1b's Manim? |
@naveen521kk Are you going to refactor the /awesome page or do you want me to have a go? |
Sure, give it a go! |
Refactored version of the /awesome page has been pushed There are two older videos that do not have thumbnails available in the webp format. I haven't created a work around as the videos are unrelated but I can look to provide backup jpg thumbnails if that would be preferred. |
Great work, looks much better! Btw should we also add a link to |
That should give a better quality pic on home page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Deploying! |
Adding the awesome-manim feed to manim-website.
See the discussion in ManimCommunity/awesome-manim#14 (comment)
The feed can be found under
/awesome
.This is work in progress.