You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add an embed flag to the ManimMagic so that the user can control whether or not videos are embded.
Currently video_embed = "google.colab" in str(get_ipython()) is hardcoded to be enabled on Google's CoLab, but there are other places this can be useful, for example, when generating documentation using Sphinx or JupyterBook.
Description of proposed feature
Add an
embed
flag to theManimMagic
so that the user can control whether or not videos are embded.Currently
video_embed = "google.colab" in str(get_ipython())
is hardcoded to be enabled on Google's CoLab, but there are other places this can be useful, for example, when generating documentation using Sphinx or JupyterBook.How can the new feature be used?
From the example:
This would embed the video in the notebook and output, allowing it to be displayed in other contexts.
Additional comments
This is a rather trivial change. I will submit a PR shortly once I explore a bit to see what the best naming options are.
References
The following may be relevant/useful:
The text was updated successfully, but these errors were encountered: