Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): upgrade base image to python3.12-slim #3458

Closed
PikaBlue107 opened this issue Nov 16, 2023 · 0 comments · Fixed by #3459
Closed

chore(docker): upgrade base image to python3.12-slim #3458

PikaBlue107 opened this issue Nov 16, 2023 · 0 comments · Fixed by #3459
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)

Comments

@PikaBlue107
Copy link
Contributor

Description of proposed feature

Currently, the manim docker image uses python3.8-slim. With the recent update to python3.12 in the main library, we should update the Dockerfile's base image to python3.12-slim to take advantage of the new support.

There's lots of nice features in python 3.9, 3.10, 3.11, and 3.12:

How can the new feature be used?

People who use the Docker distribution of manim (such as myself) can benefit from these new Python language features. In particular, one can make better use of Manim's recent type hint efforts.

Additional comments

I don't believe this should break anything; should be a simple one line change.
@PikaBlue107 PikaBlue107 added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Nov 16, 2023
PikaBlue107 pushed a commit to PikaBlue107/manim that referenced this issue Nov 16, 2023
Update Docker base image to python3.12-slim (ManimCommunity#3458)
bd92eeb
@naveen521kk naveen521kk linked a pull request Nov 17, 2023 that will close this issue
Update Docker base image to python3.12-slim (#3458) #3459
Merged
3 tasks
behackl added a commit that referenced this issue Dec 6, 2023
@PikaBlue107 @behackl
Update Docker base image to python3.12-slim (#3458) (#3459)
40766cb 
* Update Docker base image to python3.12-slim (#3458)

* Update docker/Dockerfile

---------

Co-authored-by: Melody Griesen <jvgriese@ncsu.edu>
Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
@behackl behackl mentioned this issue Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Dev Board
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Docker base image to python3.12-slim (#3458) PikaBlue107/manim
1 participant
@PikaBlue107