Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isort to pre_commit file #1270

Merged
merged 2 commits into from Apr 6, 2021

Conversation

kolibril13
Copy link
Member

@kolibril13 kolibril13 commented Apr 6, 2021

Changelog / Overview

As we might have https://pre-commit.ci/ activated soon, I think having isort automated is only beneficial.
Note that I did not run pre-commit install yet (https://pre-commit.com/#3-install-the-git-hook-scripts)
I got the isort script from here: https://github.com/PyCQA/isort/blob/07cf92116d1d880aa54f8e664804d9e8ffdfeb2a/docs/configuration/pre-commit.md

Motivation

Explanation for Changes

Testing Status

Further Comments

Checklist

  • I have read the Contributing Guidelines
  • I have written a descriptive PR title (see top of PR template for examples)
  • I have written a changelog entry for the PR or deem it unnecessary
  • My new functions/classes either have a docstring or are private
  • My new functions/classes have tests added and (optional) examples in the docs
  • My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

  • The PR title is descriptive enough
  • The PR is labeled correctly
  • The changelog entry is completed if necessary
  • Newly added functions/classes either have a docstring or are private
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

@kolibril13 kolibril13 added the infrastructure Anything related to our infrastructure label Apr 6, 2021
@kolibril13 kolibril13 marked this pull request as ready for review April 6, 2021 16:03
@RickyC0626
Copy link
Contributor

Looks good 👍🏻

@kolibril13 kolibril13 merged commit 4331817 into ManimCommunity:master Apr 6, 2021
@kolibril13 kolibril13 deleted the isort_to_pre_commit branch April 6, 2021 17:59
@behackl behackl added this to the Release v0.6.0 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything related to our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants