New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVG elliptical arc support #1475
Conversation
* Add SVG support for elliptical arcs
… arcs that are multiple of 90 degrees.
… svg-elliptical-arc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code is good - I saw a version of this earlier today.
The only blocking changes are the ones done by the CI - have you run black and isort?
One improvement I will suggest but not require is handing a
commands with 7*n numbers, not just 7. If more than 7 numbers appear after an arc command, the next 7 are interpreted as their own arc command, and so on. While this is part of the spec, I don't expect to see it all that often, so it's not a blocking issue.
Build looks good, but looks like I don't have edit access as a maintainer, so I can't update with the most recent version to perform the merge. Can you either update and ping me or allow access for maintainers? (tbh not sure where that option is) |
Changelog / Overview
Motivation
Add SVG elliptical arc support to manim.
See: https://www.w3.org/TR/SVG11/paths.html#PathDataEllipticalArcCommands
Explanation for Changes
Adds support to manim for SVGs that contain paths with elliptical arcs.
Testing Status
manim rendering https://www.w3.org/TR/SVG11/images/paths/arcs01.svg
Further Comments
Checklist
Reviewer Checklist