Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix tests #1535

Merged
merged 15 commits into from May 21, 2021

Conversation

naveen521kk
Copy link
Member

Changelog / Overview

Bump dependencies. Since click 8 is released, I have tested it and seems to work. Also, the logger interface is so stable on rich that we can use any version >6.0.0.

Motivation

Essentially, the AUR package broke and I fixed it by changing these. Also, I have locally tested things and it seems to work. Also, I have added .gitattributes files so that LF is used everywhere even on Windows(no worries git handles it smoothly).

Explanation for Changes

I bumped the version in pyproject.toml and updated the lock file.

Testing Status

Locally tested.

Checklist

  • I have read the Contributing Guidelines
  • I have written a descriptive PR title (see top of PR template for examples)
  • I have written a changelog entry for the PR or deem it unnecessary
  • My new functions/classes either have a docstring or are private
  • My new functions/classes have tests added and (optional) examples in the docs
  • My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

  • The PR title is descriptive enough
  • The PR is labeled correctly
  • The changelog entry is completed if necessary
  • Newly added functions/classes either have a docstring or are private
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

@naveen521kk
Copy link
Member Author

I think the doctest failures seem weird. How, didn't it happen before, and how does it happen how? And, the doctest failure seem's legit as we set the default log level to INFO, why didn't it happen before, maybe it was a bug in rich.

@naveen521kk naveen521kk marked this pull request as draft May 18, 2021 06:01
@naveen521kk naveen521kk marked this pull request as ready for review May 18, 2021 08:26
@naveen521kk naveen521kk changed the title Test with click 8 Update dependencies and fix tests May 18, 2021
@naveen521kk naveen521kk merged commit b726b40 into ManimCommunity:master May 21, 2021
@naveen521kk naveen521kk deleted the fix-deps branch May 21, 2021 18:48
@behackl behackl added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants