New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and fix tests #1535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naveen M K <naveen@syrusdark.website>
I think the doctest failures seem weird. How, didn't it happen before, and how does it happen how? And, the doctest failure seem's legit as we set the default log level to INFO, why didn't it happen before, maybe it was a bug in rich. |
This reverts commit 49b4c04.
huguesdevimeux
approved these changes
May 21, 2021
12 tasks
behackl
added
the
maintenance
refactoring, typos, removing clutter/dead code, and other code quality improvements
label
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
refactoring, typos, removing clutter/dead code, and other code quality improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog / Overview
Bump dependencies. Since click 8 is released, I have tested it and seems to work. Also, the logger interface is so stable on rich that we can use any version
>6.0.0
.Motivation
Essentially, the AUR package broke and I fixed it by changing these. Also, I have locally tested things and it seems to work. Also, I have added
.gitattributes
files so that LF is used everywhere even on Windows(no worries git handles it smoothly).Explanation for Changes
I bumped the version in
pyproject.toml
and updated the lock file.Testing Status
Locally tested.
Checklist
Reviewer Checklist