New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to use :class:~.Axes
and deprecate :class:~.GraphScene
#1598
Update examples to use :class:~.Axes
and deprecate :class:~.GraphScene
#1598
Conversation
… porting_graphscene
…removes need for include_numbers
Just wanted to say thanks for the effort here. I am just learning about graph stuff now and having up-to-date docs really helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purely based on looking at the rendered output: looks great, and IMO ready to ship. I have added one non-blocking comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Axes
and deprecate :class:GraphScene
~.Axes
and deprecate :class:~.GraphScene
Changelog / Overview
:class:
~.GraphScene
has been deprecated and its functionality has been shifted to :class:~.Axes
. See the updated example gallery for sample usage.Motivation
This is the final step in shifting over completely to
Axes
/CoordinateSystem
away fromGraphScene
Explanation for Changes
The examples that use
GraphScene
in the example gallery were updated. They all kept the same visuals, except for HeatDiagramPlot, which had its tick count reduced.Documentation Reference
Testing Status
Further Comments
This PR is dependent on #1472
Checklist
Reviewer Checklist