Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RightArcAngleExample for :class:~.Angle in documentation #1643

Merged
merged 4 commits into from Jun 6, 2021

Conversation

PhotonSpheres
Copy link
Member

@PhotonSpheres PhotonSpheres commented Jun 6, 2021

Changelog / Overview

Motivation

The first example in https://docs.manim.community/en/stable/reference/manim.mobject.geometry.Angle.html?highlight=angle is not rendering correctly.

Explanation for Changes

My guess is that, while changing to the meta-class system for open-gl, this dot option has been overlooked.

https://manimce--1643.org.readthedocs.build/en/1643/reference/manim.mobject.geometry.Angle.html?highlight=angle#manim.mobject.geometry.Angle

Testing Status

Further Comments

Checklist

  • I have read the Contributing Guidelines
  • I have written a descriptive PR title (see top of PR template for examples)
  • I have written a changelog entry for the PR or deem it unnecessary
  • My new functions/classes either have a docstring or are private
  • My new functions/classes have tests added and (optional) examples in the docs
  • My new documentation builds, looks correctly formatted, and adds no additional build warnings

Reviewer Checklist

  • The PR title is descriptive enough
  • The PR is labeled correctly
  • The changelog entry is completed if necessary
  • Newly added functions/classes either have a docstring or are private
  • Newly added functions/classes have tests added and (optional) examples in the docs
  • Newly added documentation builds, looks correctly formatted, and adds no additional build warnings

@PhotonSpheres PhotonSpheres added hackathon manim-hackathon related documentation Improvements or additions to documentation pr:bugfix Bug fix for use in PRs solving a specific issue:bug labels Jun 6, 2021
Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
On a side note, I don't think this will be counted for hackathon.

@naveen521kk naveen521kk removed hackathon manim-hackathon related documentation Improvements or additions to documentation labels Jun 6, 2021
@naveen521kk naveen521kk merged commit d8f5823 into ManimCommunity:main Jun 6, 2021
@PhotonSpheres PhotonSpheres deleted the angle_dot_fixed branch June 7, 2021 15:21
@behackl behackl added documentation Improvements or additions to documentation and removed pr:bugfix Bug fix for use in PRs solving a specific issue:bug labels Jul 1, 2021
@behackl behackl changed the title Fixed RightArcAngleExample in docs Fixed RightArcAngleExample for :class:~.Angle in documentation Jul 1, 2021
@behackl behackl changed the title Fixed RightArcAngleExample for :class:~.Angle in documentation Fixed RightArcAngleExample for :class:~.Angle in documentation Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants