Replaced current tree layout algorithm with SageMath's for improved layout of large trees #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
hydrobeam
changed the title
hydrobeam
approved these changes
Nov 30, 2021
| ) -> dict: | ||
| result = {root_vertex: np.array([0, 0, 0])} | ||
| scale: Union[float, tuple] = 2, | ||
| orientation: str = "down", |
There was a problem hiding this comment.
Is there any way to influence this parameter? Maybe borrowing sagemath's docs for this param + adding a test / a way to access it when creating the Graph would be nice.
There was a problem hiding this comment.
Technically yes -- however, I don't think this is very useful and the parameter is just kept here so that I don't have to refactor the remaining code. In SageMath, interacting with the plot is much more difficult than in Manim, where reversing the tree orientation is simply a matter of vertically flipping the resulting Mobject.
behackl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
See title, and the following example for trees with 100 vertices:
Current main branch:
This PR:
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist