Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded version of setup-ffmpeg CI action #2536

Merged
merged 1 commit into from Feb 9, 2022
Merged

Upgraded version of setup-ffmpeg CI action #2536

merged 1 commit into from Feb 9, 2022

Conversation

behackl
Copy link
Member

@behackl behackl commented Feb 9, 2022

Overview: What does this pull request change?

Upgraded version of GitHub action that sets up ffmpeg. Should use authenticated requests now, which have a much higher limit. Might resolve the API rate limit issue we have sometimes.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@behackl behackl added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Feb 9, 2022
ad-chaos
ad-chaos approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@ad-chaos ad-chaos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behackl behackl marked this pull request as ready for review February 9, 2022 11:48
icedcoffeeee
icedcoffeeee approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@icedcoffeeee icedcoffeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behackl behackl merged commit b09fda7 into main Feb 9, 2022
@behackl behackl deleted the upgrade-setup-ffmpeg branch February 9, 2022 11:55
@behackl behackl added infrastructure Anything related to our infrastructure and removed maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements labels Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icedcoffeeee icedcoffeeee icedcoffeeee approved these changes

@ad-chaos ad-chaos ad-chaos approved these changes

Assignees
No one assigned
Labels
infrastructure Anything related to our infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@behackl @icedcoffeeee @ad-chaos