Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting line numbers in :class:.Text when using ManimPango settings #2559

Merged
merged 1 commit into from Feb 18, 2022
Merged

Fix setting line numbers in :class:.Text when using ManimPango settings #2559

merged 1 commit into from Feb 18, 2022

Conversation

marcin-serwin
Copy link
Collaborator

@marcin-serwin marcin-serwin commented Feb 18, 2022 •
edited by behackl

Overview: What does this pull request change?

  • Fix setting line numbers in Text when using ManimPango settings

Motivation and Explanation: Why and how do your changes improve the library?

Fixes #2552

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

naveen521kk
naveen521kk approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@naveen521kk naveen521kk added issue:bug Something isn't working... For use in issues pr:bugfix Bug fix for use in PRs solving a specific issue:bug and removed issue:bug Something isn't working... For use in issues labels Feb 18, 2022
@naveen521kk naveen521kk changed the title Fix setting line numbers in Text when using ManimPango settings Fix setting line numbers in :class:Text when using ManimPango settings Feb 18, 2022
@naveen521kk naveen521kk merged commit 7fe437e into ManimCommunity:main Feb 18, 2022
@behackl behackl mentioned this pull request Feb 19, 2022
Merged
3 tasks
@behackl behackl changed the title Fix setting line numbers in :class:Text when using ManimPango settings Fix setting line numbers in :class:.Text when using ManimPango settings Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveen521kk naveen521kk naveen521kk approved these changes

Assignees
No one assigned
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text position issue when using both newline and t2c
2 participants
@marcin-serwin @naveen521kk