Fixed Display Issue with Custom Axis Labels When renderer=opengl
#3211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3069
Overview: What does this pull request change?
Fixes the issue causing axis labels being rendered incorrectly when
renderer=opengl
.Typically when custom labels are applied (ex. LogScaling),
NumberLine
creates the labels by callinglabel_constructor
withlabel_tex
iflabel_tex
is not aVMobject
instance.Issues arise when
label_tex
is of instanceOpenGLVMobject
. Sincelabel_constructor
is classMathTex
by default which is supposed to takestr
as arguments,OpenGLMobject.__str__
is consequently called and passed intolabel_constructor
.Further Information and Comments
Example: Logarithmic Scaling
Test code
Before
After
Example: Change Axis Label
Test code
Before
After
Reviewer Checklist