New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to remove non-svg LaTeX files #3322
Added ability to remove non-svg LaTeX files #3322
Conversation
I would not remove the .tex file itself. I don't know if it is needed for the caching algorithm, but anyway, it's quite useful for debugging. |
…2/manim into latex_junk_remover
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@uwezi I have modified the code to fit your suggestion :) (For anyone looking at this [weird] commit history, I had a bunch of weird merge problems) |
I will move these changes from |
for more information, see https://pre-commit.ci
…2/manim into latex_junk_remover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a bit more here to do; I've left some comments, please take a look. Thanks for your work!
Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
…2/manim into latex_junk_remover
for more information, see https://pre-commit.ci
…2/manim into latex_junk_remover
Overview: What does this pull request change?
--no_latex_cleanup
.aux
,.dvi
, and other files.--no_latex_cleanup
, they will not get cluttered with the.aux
,.dvi
, and other files for that expression.Motivation and Explanation: Why and how do your changes improve the library?
Often, for big manim projects, the
media/Tex
folder can get quite full with uneeded files. This PR gives users the option to have manim delete these files automatically, instead of having to manually delete said files.Further Information and Comments
This will automatically delete ALL files without the
.tex
or.svg
suffix in themedia/Tex
directory. It will only perform this ifTex
orMathTex
is used and the CLI flag--no_latex_cleanup
has not been passed.Reviewer Checklist