Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update typing guidelines #3704

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

JasonGrace2282
Copy link
Contributor

@JasonGrace2282 JasonGrace2282 commented Apr 15, 2024

  • Add preference for npt.NDArray over np.ndarray
  • Talk about Self

https://manimce--3704.org.readthedocs.build/en/3704/contributing/docs/typings.html

@JasonGrace2282 JasonGrace2282 added the documentation Improvements or additions to documentation label Apr 15, 2024
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review April 15, 2024 23:41
@JasonGrace2282 JasonGrace2282 merged commit 5139765 into ManimCommunity:main Apr 17, 2024
18 checks passed
@JasonGrace2282 JasonGrace2282 deleted the typing-docs branch April 17, 2024 01:40
JasonGrace2282 added a commit to JasonGrace2282/manim that referenced this pull request Apr 20, 2024
* Update typing guidelines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix formatting

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants