Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering loop to experimental #3707

Merged
merged 40 commits into from
May 2, 2024

Conversation

JasonGrace2282
Copy link
Contributor

@JasonGrace2282 JasonGrace2282 commented Apr 16, 2024

Adds in the rendering loop. TL;DR, the following now works

class Demo(Scene):
    def construct(self):
        self.play(DrawBorderThenFill(ManimBanner()))

The camera and interactivity still need to be added

Breaking Changes

Completed

  • Added a RenderManager
  • Separate Animation from Scene
  • Get the "typical manim" render loop going

TBD

These are TODOs for Experimental, not neccessarily for this PR

  • Optimization Galore
    • Rewrite Bézier curves (Mobject.points) to be relative to center of Mobject
  • Rebase with main (likely after this PR is merged)
  • Yank out Cairo Mobjects
  • Make RenderManager manage Scene and Window instead of Scene managing RenderManager and Window

@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review May 2, 2024 02:40
@MrDiver MrDiver merged commit 22844a2 into ManimCommunity:experimental May 2, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants