Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize VMobject.pointwise_become_partial() #3760

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chopan050
Copy link
Contributor

@chopan050 chopan050 commented May 14, 2024

Overview: What does this pull request change?

Related PR: #3292

Optimized VMobject.pointwise_become_partial() so that, instead of building the points array by repeatedly appending points to a NumPy array (which is inefficient), it now creates a single empty array from the beginning to allocate all the points.

Motivation and Explanation: Why and how do your changes improve the library?

Animations like Create, DrawBorderThenFill and Write are based on incrementally showing parts of VMobjects, so these would be benefited by this change.

Links to added or changed documentation pages

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

None yet

1 participant