Optimize VMobject.pointwise_become_partial()
#3760
Open
+65
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopan050
added
the
pr:easy review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Related PR: #3292
Optimized
VMobject.pointwise_become_partial()so that, instead of building the points array by repeatedly appending points to a NumPy array (which is inefficient), it now creates a single empty array from the beginning to allocate all the points.Motivation and Explanation: Why and how do your changes improve the library?
Animations like
Create,DrawBorderThenFillandWriteare based on incrementally showing parts of VMobjects, so these would be benefited by this change.Links to added or changed documentation pages
Reviewer Checklist