New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 183: "t values issue that causes the animations to not be finished entirely" #698
Closed
Closed
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d831aa6
first attempt
leotrs 02fe66c
update all mobjects each time we update the frame
leotrs a1a7fa5
add changes from #710
leotrs 116429b
mobjects should be updated each time the frame is updated, not only w…
leotrs 15f033a
use the camera frame rate, not the config frame rate
leotrs 1d0858b
black
leotrs bfe7f4f
Merge branch 'master' of github.com:ManimCommunity/manim
leotrs ab5e04e
Merge branch 'master' of github.com:ManimCommunity/manim
leotrs 07b6144
Merge branch 'master' of github.com:ManimCommunity/manim
leotrs d64eba2
Merge branch 'master' into fix-183
leotrs 69f5465
add conditional
leotrs 5dfd51a
fix play count
leotrs 207afdb
update tests
leotrs 2582b38
black
leotrs 3444992
add better comparison of floats
leotrs bd19fa2
be more lenient when comparing floats
leotrs d7fa9bd
add new test
leotrs 0876e31
add useless lines - these are overwritten by how GraphicalUnitsTester…
leotrs b9d8f46
change test to use colors, not Text
leotrs 0e06786
black
leotrs File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-2.84 KB
(46%)
tests/control_data/graphical_units_data/last_frame/LastFrame.npz
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment/issue : I'm worry that it won't test anything, as graphical unit tests are run with the equivalent of
-s
flag ( every animation is skipped)therfore, the last t value is always the run_time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this tests the change either...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going through older issues/PRs again and recall @kolibril13 mentioning a way to test video which is VERY applicable here as a way to test this PR. #1035
I recommend we test in this manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the record, in #1019 I Implemented such tests on t values, so no need to implement this here.