New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: allow new-style method animation to be used in animation groups #906
Bugfix: allow new-style method animation to be used in animation groups #906
Conversation
Perhaps there should be a single function to handle this stuff that could be used in def handle_animation(anim):
if isinstance(anim, _AnimationBuilder):
return anim.build()
if isinstance(anim, Animation):
return anim
raise TypeError(...) |
dd54e1f now delegates building of an animation from an animation factory to a dedicated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just have a couple not very important nitpicks
Co-authored-by: friedkeenan <friedkeenan@protonmail.com>
…manim into animationbuilder-animationgroup
Motivation
New-style method animations (using the
.animate
syntax) can't currently be included inAnimationGroup
orSuccession
.Overview / Explanation for Changes
With this change, animations in the list are checked whether they are a
_AnimationBuilder
-- and if so, the corresponding animation is built and added toself.animations
.Oneline Summary of Changes
Testing Status
Added a test for
AnimationGroup
andSuccession
, passing locally.Acknowledgements
Reviewer Checklist