Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error if markup in MarkupText is invalid #920

Merged
merged 7 commits into from Jan 12, 2021

Conversation

PhilippImhof
Copy link
Member

This is linked to ManimCommunity/ManimPango#8 and ManimCommunity/ManimPango#9.

As soon as the other PR is merged, MarkupText will raise an error when the markup is invalid, e.g. invalid tags or valid unbalanced tags.

from manim import *

class TestValidation(Scene):
    def construct(self):
        text1=MarkupText("bla") 
        text2=MarkupText("<b>bla</b>") 
        text3=MarkupText('<color col="RED">bla</color>')
        text4=MarkupText("<asdf>bla</asdf>")
        text5=MarkupText("<b>bla")

The last two will fail, the others will be OK.

@PhilippImhof
Copy link
Member Author

PhilippImhof commented Jan 10, 2021

Setting this to draft as long as ManimPango is not updated, because it will obviously break MarkupText.

No permissions. @naveen521kk could you please.

@naveen521kk naveen521kk marked this pull request as draft January 10, 2021 11:37
@naveen521kk naveen521kk marked this pull request as ready for review January 11, 2021 09:44
@naveen521kk
Copy link
Member

I have released a v0.1.6. Update to that, by setting that as the minimum using poetry and update.

@PhilippImhof PhilippImhof self-assigned this Jan 12, 2021
@naveen521kk
Copy link
Member

Also, set the minimum version to v0.1.6 in pyproject.toml

@PhilippImhof PhilippImhof merged commit 18af804 into ManimCommunity:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants