Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized the code #11

Closed
wants to merge 1 commit into from
Closed

Optimized the code #11

wants to merge 1 commit into from

Conversation

TheShiveshNetwork
Copy link

@TheShiveshNetwork TheShiveshNetwork commented Oct 7, 2023

#10 Fix

Fixes Issue

This PR resolves a small optimization issue

Proposed Changes

Just remove the unused variables and imports to optimize the code

Checklist (Check all applicable boxes)

  • My code adheres to the project's coding style.
  • My changes require updates to the project's documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests have passed successfully.
  • This PR does not contain any plagiarized content.
  • The title of my pull request provides a brief description of the requested changes.
  • I am contributing independently.
  • I am contributing for Hacktoberfest 2023.

Potential Impact on Existing Code

Screenshots

Reviewer Notes

@ManishaSwain8
Copy link
Owner

@TheShiveshNetwork its good that you have interest, but never make PR if you are not assigned to it ,in this PR will not get merged.

@ManishaSwain8 ManishaSwain8 added the invalid This doesn't seem right label Oct 7, 2023
@TheShiveshNetwork
Copy link
Author

@TheShiveshNetwork its good that you have interest, but never make PR if you are not assigned to it ,in this PR will not get merged.

Alright, I am new to open source and still learning. No problem.

@ManishaSwain8
Copy link
Owner

ManishaSwain8 commented Oct 7, 2023

@TheShiveshNetwork no problem ! In open source it is good practice to raise the issue and wait for it to be assigned , this helps both maintainer and contributor, never work on something unless it is not assigned to you.
We all learn from our mistakes only 😊

Looking forward for more issues and collaboration from you . !!!
Thanks for your time .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants