Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the host triple from rustc instead of using a static value #13

Merged
merged 1 commit into from
May 17, 2015

Conversation

laumann
Copy link
Collaborator

@laumann laumann commented May 15, 2015

Fixes #12

@laumann
Copy link
Collaborator Author

laumann commented May 15, 2015

@Ryman Do you think this solution will work?

@Ryman
Copy link
Contributor

Ryman commented May 15, 2015

I'm unsure, this would work for my case, but probably doesn't help for people doing cross-compiles.

I thought Cargo sets env vars, but it seems it only does it for build scripts. Perhaps compiletest could use a buildscript to grab these from cargo and then load them via include!(concat!(env!("OUT_DIR"), "/targets.rs")); within compiletest itself (hidden form usercode).

Maybe keeping it simple is best to start with, but you might want to get an opinion from someone more knowledgeable on the build script story!

@laumann
Copy link
Collaborator Author

laumann commented May 17, 2015

Ok, I think we'll deal with requirements for cross-compiles as they arise and I'll keep the build script idea in mind. Thanks for the input 😄

laumann pushed a commit that referenced this pull request May 17, 2015
Fetch the host triple from rustc instead of using a static value
@laumann laumann merged commit 7f8026a into master May 17, 2015
@laumann laumann deleted the issue-12 branch May 17, 2015 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default config's target could be better
2 participants