Fix most Clippy warnings #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#borrow_as_ptr https://rust-lang.github.io/rust-clippy/master/index.html#ptr_as_ptr Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#items_after_statements Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned Signed-off-by: Anders Kaseorg <andersk@mit.edu>
https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Manishearth
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.