Save allocation by keeping empty lists in _effectsToUpdate #47
Conversation
Previously, when there were additional bone effects, lists inside _effectsToUpdate had to be reallocated every frame. This patch fixes the issue by keeping empty lists around.
| @@ -551,6 +554,12 @@ private void ApplyEffects() | |||
| FixBustGravity(); | |||
| } | |||
| } | |||
|
|
|||
| if (_effectsToUpdate.Count > 2 * numEffects) | |||
There was a problem hiding this comment.
It looks like _effectsToUpdate will be Cleared if there are more than 2 plugins with effects affecting the same bones.
There was a problem hiding this comment.
I don't think this is the case. Having another plugin that affects the same bones would not increase _effectsToUpdate.Count. It would increase the sizes of inner lists instead. Also it would increase numEffects, so it would cause _effectsToUpdate to be cleared less often, if anything.
Now admittedly this is all confusing... The idea was that I wanted to prevent _effectsToUpdate from growing indefinitely.
No worries, thanks for your review! |
Previously, when there were additional bone effects, lists inside
_effectsToUpdatehad to be reallocated every frame. This patch fixes the issue by keeping empty lists around.