Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

230 basic linting #231

Merged
merged 6 commits into from
Jun 18, 2024
Merged

230 basic linting #231

merged 6 commits into from
Jun 18, 2024

Conversation

mschwoer
Copy link
Collaborator

@mschwoer mschwoer commented Jun 17, 2024 •
edited
Loading

  • update branch checks to use the workflow like alphabase
  • add checks offered by pre-commit hook to CI
  • reformat few files to make pre-commit check pass

@mschwoer mschwoer linked an issue Jun 17, 2024 that may be closed by this pull request
Basic linting #230
Closed
@mschwoer mschwoer requested a review from GeorgWa June 17, 2024 16:19
GeorgWa
GeorgWa approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mschwoer mschwoer changed the base branch from main to development June 18, 2024 07:21
@mschwoer mschwoer merged commit 75e1dcb into development Jun 18, 2024
8 checks passed
@mschwoer mschwoer deleted the 230-basic-linting branch June 18, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic linting
2 participants
@mschwoer @GeorgWa