Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#488: fix error when scoring on machines with more than 60 cpus #489

Merged
merged 2 commits into from
Aug 11, 2022
Merged

#488: fix error when scoring on machines with more than 60 cpus #489

merged 2 commits into from
Aug 11, 2022

Conversation

mschwoer
Copy link
Contributor

The value of the n_processes setting was not passed to train_RF(), thus always circumventing the check implemented in 7e989bc
solution:

  • pass n_processes settings to score.py:train_RF().
  • make train_RF() itself robust against this issue, introduce another cpu core check
  • cleaned up formatting of train_RF()

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@straussmaximilian straussmaximilian changed the base branch from master to develop August 11, 2022 15:29
@straussmaximilian straussmaximilian merged commit b310d1d into MannLabs:develop Aug 11, 2022
@straussmaximilian straussmaximilian mentioned this pull request Oct 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straussmaximilian straussmaximilian straussmaximilian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mschwoer @straussmaximilian