Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an environment variable for gitlab url #10

Merged
merged 1 commit into from
May 28, 2024

Conversation

fleboulch
Copy link
Contributor

No description provided.

.env.test Outdated Show resolved Hide resolved
@fleboulch fleboulch changed the title fix: Add an environment variable for gitlab url Draft: fix: Add an environment variable for gitlab url May 21, 2024
@fleboulch fleboulch changed the title Draft: fix: Add an environment variable for gitlab url Add an environment variable for gitlab url May 21, 2024
@fleboulch fleboulch marked this pull request as draft May 21, 2024 13:50
@fleboulch fleboulch marked this pull request as ready for review May 27, 2024 08:53
@greg0ire greg0ire requested a review from pfongkye May 27, 2024 11:15
@fleboulch fleboulch force-pushed the fix-hardcoded-gitlab-url branch 2 times, most recently from 3d15f11 to e27579e Compare May 27, 2024 12:33
README.md Outdated Show resolved Hide resolved
.env.test Outdated Show resolved Hide resolved
@fleboulch
Copy link
Contributor Author

@pfongkye I did the update

@pfongkye
Copy link

Thanks @fleboulch 👍

@fleboulch
Copy link
Contributor Author

I don't know why the CI is failing. My change should not break it

@greg0ire
Copy link
Member

@fleboulch I tried opening another PR, and its build passes though: #14

@greg0ire
Copy link
Member

I just restarted the failed job, in case this was transient.

@greg0ire
Copy link
Member

Still fails :(

There are other occurrences of git.manomano.tech in the project:

$ rg 'git.manomano'
__mocks__/node-fetch.ts
11:  if (url.includes('git.manomano.tech') || url.includes('slack')) {

src/core/typings/GitlabUser.ts
9:  /** URL of user profile (ex: https://git.manomano.tech/josselin.buils) */

Please change them, I bet changing the first one will fix the build.

@fleboulch
Copy link
Contributor Author

Thanks @greg0ire!
I think this build will be green!
That's why when I opened this PR I did a change without changing any hardcoded value...

@greg0ire greg0ire merged commit 5168527 into ManoManoTech:main May 28, 2024
1 check passed
@greg0ire
Copy link
Member

Thanks @fleboulch !

@fleboulch fleboulch deleted the fix-hardcoded-gitlab-url branch May 28, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants