Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manta API: AssetMetadata upgrade #289

Merged
merged 49 commits into from Jan 26, 2023
Merged

Manta API: AssetMetadata upgrade #289

merged 49 commits into from Jan 26, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Dec 2, 2022 •
edited

AssetMetadata upgrade. To be merged after (#286). Changes:

manta-accounting:

  • asset.rs: Removed the AssetMetadata struct.
  • transfer::canonical: Removed display method for Transaction.
  • wallet::signer: Made AssetMetadata an associated type for both Connection and Configuration. Changed the SignRequest struct so it takes a generic metadata field.

manta-pay:

  • signer: Defined a new AssetMetadata struct which supports NFT display with display implementations.
  • signer::client and signer::base: Added AssetMetadata as the corresponding type for both the Connection and the Configuration implementations.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

SupremoUGH and others added 30 commits November 24, 2022 12:27
@SupremoUGH
utxo protocol
33e76eb 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
utxo finished
7b5f578 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
sender and receiver
7d2874d 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
transfer mod finished
5896feb 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
wallet done
d762ad6 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
mantapay config
19c49ea 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
mantapay config works
d5a9e62 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
tests
63a3de4 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
signer base fixed
b2720e2 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
signer client
2e1a03b 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
parameters + testing
4f9a6bb 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
parameters, test, simulation and binaries
eed927e 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
benchmark
f5d957e 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
sdk
9905cde 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
re-exports in manta-pay
4a714cf 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
feature issue solved
7eda1b1 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
docs
9853cdf 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
changelog
9fbbdf5 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
sample impls revised
c4e0eec 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
sample issue solved in tests
a451d2e 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
balance tests
83ba1dd 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
DEFAULT_BRANCH changed
5ce37e4 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
zero signature issue tested and fixed
ce575e7 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH @bhgomes
Apply suggestions from code review
7d31418 
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Francisco Hernández Iglesias <38819712+SupremoUGH@users.noreply.github.com>
@SupremoUGH
some comments addressed
1982dd6 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
more comments addressed
5b811bc 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
sample issue solved
655b194 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
public fields made private again
e481aec 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
compat deleted
c7b1e94 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
FIXME
6142d47 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
changelog
ce92a28 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH SupremoUGH added the changelog:added Changelog: add these changes to the `added` section of the changelog label Dec 2, 2022
@SupremoUGH SupremoUGH self-assigned this Dec 2, 2022
@SupremoUGH SupremoUGH marked this pull request as ready for review December 2, 2022 13:09
@SupremoUGH SupremoUGH marked this pull request as draft December 2, 2022 13:13
SupremoUGH and others added 8 commits December 2, 2022 14:47
@SupremoUGH
clippy issues
865f0a3 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
now AssetMetadata is part of signer connection and signer configuration
17abb0a 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
docs
88a8be0 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
docs
e2df72f 
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
@SupremoUGH
merge main
19ce634
@bhgomes
Merge branch 'main' into feat/manta-api-assetmetadata
d24c707 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
Merge branch 'main' into feat/manta-api-assetmetadata
5560192 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
chore: fix Rust upgrade warnings
a0e3236 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
This was referenced Jan 10, 2023
Closed
Open
@SupremoUGH SupremoUGH marked this pull request as ready for review January 24, 2023 12:16
ferrell-code
ferrell-code reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the onchain storage of manta pay? Then it would break the testnet, I don't think it does though, but want to make sure

This should only effects signer and sdk to my understanding

manta-pay/src/signer/mod.rs Show resolved Hide resolved
@bhgomes bhgomes merged commit 4323cac into main Jan 26, 2023
@bhgomes bhgomes deleted the feat/manta-api-assetmetadata branch January 26, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees

@SupremoUGH SupremoUGH

Labels
changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SupremoUGH @bhgomes @ferrell-code