Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the correct identity verification logic #313

Merged
merged 2 commits into from Jan 30, 2023
Merged

fix: use the correct identity verification logic #313

merged 2 commits into from Jan 30, 2023

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jan 30, 2023 •
edited

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

  • Switched to is_zero instead of is_empty
  • Updated dependencies

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@bhgomes
fix: use the correct identity verification logic
61c72ff 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes added the changelog:fixed Changelog: add these changes to the `fixed` section of the changelog label Jan 30, 2023
@bhgomes
chore: add CHANGELOG entry
bd457d8 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes marked this pull request as ready for review January 30, 2023 15:20
@bhgomes bhgomes merged commit 6824ecb into main Jan 30, 2023
@bhgomes bhgomes deleted the fix/identity-verification branch January 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

Assignees
No one assigned
Labels
changelog:fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhgomes @SupremoUGH @ferrell-code