Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions in signer #336

Merged
merged 70 commits into from Apr 7, 2023
Merged

Permissions in signer #336

merged 70 commits into from Apr 7, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Apr 5, 2023 •
edited

The functions address, and transaction_data only require the signer to have a loaded AuthorizationContext and not an AccountMap. The same applies to sign for ToPrivate transactions.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

SupremoUGH and others added 30 commits March 14, 2023 17:49
@SupremoUGH SupremoUGH self-assigned this Apr 6, 2023
@SupremoUGH SupremoUGH added the changelog:changed Changelog: add these changes to the `changed` section of the changelog label Apr 6, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review April 6, 2023 12:25
@SupremoUGH SupremoUGH merged commit cad6ed3 into main Apr 7, 2023
17 checks passed
@SupremoUGH SupremoUGH deleted the permissions_in_signer branch April 7, 2023 17:40
@SupremoUGH SupremoUGH mentioned this pull request Apr 7, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqhxuyuan zqhxuyuan zqhxuyuan approved these changes

@Apokalip Apokalip Apokalip approved these changes

Assignees

@SupremoUGH SupremoUGH

Labels
changelog:changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SupremoUGH @zqhxuyuan @Apokalip @bhgomes