Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precompute Ledger and overflow bug fix #345

Merged
merged 22 commits into from May 18, 2023
Merged

Precompute Ledger and overflow bug fix #345

merged 22 commits into from May 18, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented May 9, 2023 •
edited

Sets up a testing environment which can precompute a ledger and create a wallet from a precomputed ledger.
Fixes a minor overflow bug with the wallet balance.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Checked that changes and commits conform to the standards outlined in CONTRIBUTING.md.

@SupremoUGH SupremoUGH added changelog:added Changelog: add these changes to the `added` section of the changelog A-testing Area: Testing-related Issues and PRs labels May 16, 2023
@SupremoUGH SupremoUGH self-assigned this May 16, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review May 16, 2023 19:41
@SupremoUGH SupremoUGH changed the title Signer bug good Precompute Ledger and overflow bug fix May 16, 2023
@SupremoUGH SupremoUGH requested a review from zqhxuyuan May 17, 2023 17:07
ghzlatarev
ghzlatarev previously approved these changes May 18, 2023
View reviewed changes
@SupremoUGH SupremoUGH merged commit 019a4aa into main May 18, 2023
33 of 34 checks passed
@SupremoUGH SupremoUGH deleted the signer_bug_good branch May 18, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqhxuyuan zqhxuyuan zqhxuyuan approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

Assignees

@SupremoUGH SupremoUGH

Labels
A-testing Area: Testing-related Issues and PRs changelog:added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SupremoUGH @zqhxuyuan @ghzlatarev