DO NOT MERGE: feat: upgrade to new crypto primitives #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoyuanFeng
reviewed
May 30, 2022
BoyuanFeng
reviewed
May 30, 2022
BoyuanFeng
reviewed
May 30, 2022
bhgomes
changed the title
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
BoyuanFeng
suggested changes
Jun 17, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
tsunrise
reviewed
Jun 21, 2022
4 tasks
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
BoyuanFeng
suggested changes
Jun 21, 2022
| /// Builds a new [`State`] from `state`. | ||
| #[inline] | ||
| pub fn new(state: Box<[S::Field]>) -> Self { | ||
| assert_eq!(state.len(), S::WIDTH); |
There was a problem hiding this comment.
assert_eq makes code slower. Should we change to the following?
if state.len() != S::WIDTH {
return None;
}There was a problem hiding this comment.
How does it make it slower? Using None here is slower.
Comment on lines
+280
to
+290
| let linear_combination = state | ||
| .iter() | ||
| .enumerate() | ||
| .map(|(j, elem)| S::mul_const(elem, &self.mds_matrix[S::WIDTH * i + j], compiler)) | ||
| .collect::<Vec<_>>(); | ||
| next.push( | ||
| linear_combination | ||
| .into_iter() | ||
| .reduce(|acc, next| S::add(&acc, &next, compiler)) | ||
| .unwrap(), | ||
| ); |
There was a problem hiding this comment.
Consider using the following:
next.push(
state
.iter()
.enumerate()
.map(|(j, elem)| S::mul_const(elem, &self.mds_matrix[S::WIDTH * i + j], compiler))
.reduce(|acc, next| S::add(&acc, &next, compiler))
.unwrap(),
);There was a problem hiding this comment.
This doesn't work because of the double borrow of compiler. See the clippy false-positive note above.
| #[inline] | ||
| fn first_round_with_domain_tag_unchecked<const N: usize>( | ||
| &self, | ||
| domain_tag: &S::Field, |
There was a problem hiding this comment.
Following our discussion with Dmitry, we can set domain_tag as S::ParamterField to reduce a few constraints.
| S: Specification<COM>, | ||
| S::ParameterField: Field + FieldGeneration + PartialEq + Sample<D>, | ||
| { | ||
| /// Samples random Poseidon parameters. |
There was a problem hiding this comment.
Should we delete this comment to match the code style of other impl?
| /// The encryption key is the information required to produce a valid ciphertext that is targeted | ||
| /// towards some [`DecryptionKey`](DecryptionKeyType::DecryptionKey). In the case when the | ||
| /// decryption key is linked by some computable protocol to the encryption key, [`Derive`] should be | ||
| /// implemented to fascilitate this derivation. |
There was a problem hiding this comment.
fascilitate => facilitate
| /// The decryption key is the information required to open a valid ciphertext that was encrypted | ||
| /// with the [`EncryptionKey`](EncryptionKeyType::EncryptionKey) that was targeted towards it. In | ||
| /// the case when the decryption key is linked by some computable protocol to the encryption key, | ||
| /// [`Derive`] should be implemented to fascilitate this derivation. |
There was a problem hiding this comment.
fascilitate => facilitate
| /// Encryption | ||
| pub trait Encrypt<COM = ()>: EncryptionTypes { | ||
| /// Encrypts `plaintext` with the `encryption_key` and the one-time encryption `randomness`, | ||
| /// including `header`, but not necessarily encrypting it. |
There was a problem hiding this comment.
What it refers to here?
There was a problem hiding this comment.
The header. I'll rewrite.
bhgomes
changed the title
bhgomes
added
DO-NOT-MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE WHEN #149 IS MERGED
We need to add the following cryptographic primitives to get ready for the v1.0.0 release:
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.