signer v2 #10
Merged
signer v2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2021 00:38
stechu
reviewed
Oct 1, 2021
| import "unsafe" | ||
|
|
||
|
|
||
| type TransactioBatchSummary struct { |
There was a problem hiding this comment.
Add comments here? For example, what are the valid transactionType? what is a denomination.
Does these types have to be string because of FFI?
bhgomes
approved these changes
Oct 1, 2021
added 2 commits
October 5, 2021 01:44
|
@Kevingislason feel free to merge it if you think it is ready to go! |
Rust code is not building anymore due to changes to Edit: just kidding, needed to cargo update |
|
@Kevingislason There were some feature changes that I also pinged you on in another PR, related to |
bhgomes
added
the
L-changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some important supplemental updates to the MVP version of signer:
-Display transaction info when confirming transactions
-Allow for mnemonic recovery
-Improve UI feedback
-Simplified and modestly improved UI styling
-Improve error handling in Rust code
todo: change manta-api branch to
mantaafter mergingsigner_batching_auxiliary