New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage abstractions and add server storage hook #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bhgomes
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-added
Changelog: add these changes to the `added` section of the changelog
P-medium
Priority: Medium
A-design
Area: Design of Libraries and APIs
labels
Jul 27, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Kevingislason
previously approved these changes
Jul 27, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Kevingislason
approved these changes
Jul 29, 2022
codecarrier1
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dp3000
added a commit
that referenced
this pull request
Aug 5, 2022
…signer into e2e-testing * 'e2e-testing' of https://github.com/Manta-Network/manta-signer: Add storage abstractions and add server storage hook (#154) Repository Cleanup (#151)
dp3000
pushed a commit
that referenced
this pull request
Aug 8, 2022
* feat: add storage abstractions and add server storage hook * chore: add CHANGELOG entry * feat: add optimized README image * chore: update manta-rs dependencies Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-design
Area: Design of Libraries and APIs
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-added
Changelog: add these changes to the `added` section of the changelog
P-medium
Priority: Medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store
which generalizes thePasswordStore
objectPasswordStoreHandle
as not neededServerStore
for the entire server state: now we can query arbitrary parts of the server and run any standard functions on it from Tauri directlyBefore we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.md
and added the appropriatechangelog
label to the PR.Files changed
in the GitHub PR explorer.