Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage abstractions and add server storage hook #154

Merged
merged 4 commits into from Jul 29, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jul 27, 2022

  • Add storage abstraction Store which generalizes the PasswordStore object
  • Remove PasswordStoreHandle as not needed
  • Add ServerStore for the entire server state: now we can query arbitrary parts of the server and run any standard functions on it from Tauri directly

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 11:45PM (UTC)

@bhgomes bhgomes added C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Changelog: add these changes to the `added` section of the changelog P-medium Priority: Medium A-design Area: Design of Libraries and APIs labels Jul 27, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Kevingislason
Kevingislason previously approved these changes Jul 27, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Copy link
Contributor

@codecarrier1 codecarrier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhgomes bhgomes merged commit 0e807a0 into main Jul 29, 2022
@bhgomes bhgomes deleted the feat/server-state-store branch July 29, 2022 18:02
@Kevingislason Kevingislason modified the milestones: v0.8.0, v0.7.4 Aug 4, 2022
dp3000 added a commit that referenced this pull request Aug 5, 2022
…signer into e2e-testing

* 'e2e-testing' of https://github.com/Manta-Network/manta-signer:
  Add storage abstractions and add server storage hook (#154)
  Repository Cleanup (#151)
dp3000 pushed a commit that referenced this pull request Aug 8, 2022
* feat: add storage abstractions and add server storage hook
* chore: add CHANGELOG entry
* feat: add optimized README image
* chore: update manta-rs dependencies

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@Kevingislason Kevingislason mentioned this pull request Oct 14, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-design Area: Design of Libraries and APIs C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Changelog: add these changes to the `added` section of the changelog P-medium Priority: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants