Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for old storage file before deleting it #204

Merged
merged 3 commits into from Nov 3, 2022

Conversation

AlexParshh
Copy link
Contributor

@AlexParshh AlexParshh commented Nov 3, 2022

Fix to check for storage file before we delete it to replace it with backup file. This is an edge case where only the backup file exists without the storage file upon startup and would cause a crash if we tried to delete a non-existing storage file.


Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@vercel
Copy link

vercel bot commented Nov 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 5:40PM (UTC)

@AlexParshh AlexParshh merged commit a29f3ec into main Nov 3, 2022
@AlexParshh AlexParshh deleted the fix/backup-recover2 branch November 3, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants