Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tray Secret Phrase Window not Opening, and X button closing Signer instead of minimizing #250

Merged
merged 10 commits into from Jan 23, 2023
Merged

Tray Secret Phrase Window not Opening, and X button closing Signer instead of minimizing #250

merged 10 commits into from Jan 23, 2023

Conversation

Apokalip
Copy link
Contributor

closes: #231
closes: #249

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@Apokalip
Adding ready state to keep main window from closing
8a613ff 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
fixing secret phrase not opening and X button closing signer. Ready S…
b241d41 
…tate and proper export abort

Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip Apokalip self-assigned this Jan 10, 2023
@vercel
Copy link

vercel bot commented Jan 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
manta-signer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 0:46AM (UTC)

@Apokalip
format
474128c 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
Adding ready state to keep main window from closing
782f7e9 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
fixing secret phrase not opening and X button closing signer. Ready S…
4abff43 
…tate and proper export abort

Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
format
9589118 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
Merge branch 'tray_window_closure' of https://github.com/Manta-Networ…
abc739a 
…k/manta-signer into tray_window_closure
@Apokalip Apokalip requested review from Boyuan-Deng and removed request for AlexParshh January 11, 2023 16:40
@Apokalip Apokalip added C-bug Category: Issues documenting a bug L-fixed Changelog: add these changes to the `fixed` section of the changelog P-high Priority: High A-tauri Area: Issues and PRs related to Tauri A-ui Area: Issues and PRs related to UI labels Jan 11, 2023
Boyuan-Deng
Boyuan-Deng approved these changes Jan 13, 2023
View reviewed changes
Copy link

@Boyuan-Deng Boyuan-Deng left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javascript code looks good. Cannot say much about the Rust code. Tested the signer and is working great.

@Apokalip
Merge branch 'main' into tray_window_closure
1daa16c 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip Apokalip merged commit 9f709e6 into main Jan 23, 2023
@Apokalip Apokalip deleted the tray_window_closure branch January 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevingislason Kevingislason Kevingislason approved these changes

@Boyuan-Deng Boyuan-Deng Boyuan-Deng approved these changes

@bhgomes bhgomes Awaiting requested review from bhgomes

Assignees

@Apokalip Apokalip

Labels
A-tauri Area: Issues and PRs related to Tauri A-ui Area: Issues and PRs related to UI C-bug Category: Issues documenting a bug L-fixed Changelog: add these changes to the `fixed` section of the changelog P-high Priority: High
Projects
None yet
Milestone
No milestone
3 participants
@Apokalip @Kevingislason @Boyuan-Deng