Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authorization #289

Merged
merged 8 commits into from Feb 13, 2023
Merged

Fix authorization #289

merged 8 commits into from Feb 13, 2023

Conversation

Apokalip
Copy link
Contributor

@Apokalip Apokalip commented Feb 6, 2023 •
edited

Signed-off-by: Apokalip simeon@manta.network

closes: #281
closes: #280
closes: #242
closes: #232

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@Apokalip
Fix authorization
ea4ac33 
Signed-off-by: Apokalip <simeon@manta.network>
@vercel
Copy link

vercel bot commented Feb 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
manta-signer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 3:14PM (UTC)

@Apokalip Apokalip self-assigned this Feb 6, 2023
@Apokalip
fmt
725b0b9 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
clean up js imports
19c7687 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
Updates on aborting process/password cancelation
bbecce9 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
fixing info! error
0856e3b 
Signed-off-by: Apokalip <simeon@manta.network>
Kevingislason
Kevingislason reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@Kevingislason Kevingislason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. My only suggestion is to maintain the convention where we put tags at the beginning of logs (like [INFO]:) in the new places we're logging

@Apokalip Apokalip added C-bug Category: Issues documenting a bug L-fixed Changelog: add these changes to the `fixed` section of the changelog labels Feb 11, 2023
@Apokalip
refactor logs
90e2394 
Signed-off-by: Apokalip <simeon@manta.network>
Kevingislason
Kevingislason previously approved these changes Feb 12, 2023
View reviewed changes
@Apokalip
Changelog
ac74640 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip Apokalip merged commit b69abf8 into main Feb 13, 2023
@Apokalip Apokalip deleted the auth_fix branch February 13, 2023 15:43
This was referenced Mar 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@Kevingislason Kevingislason Kevingislason approved these changes

Assignees

@Apokalip Apokalip

Labels
C-bug Category: Issues documenting a bug L-fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Milestone
No milestone
3 participants
@Apokalip @bhgomes @Kevingislason