Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sinks validation #332

Merged
merged 10 commits into from Mar 8, 2023
Merged

Add sinks validation #332

merged 10 commits into from Mar 8, 2023

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Mar 6, 2023 •
edited

Description

  • Adds sinks validation in manta-rs to signer
  • Updates to use new metadata type that includes NFTs
  • Uses new SignerState api

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@ferrell-code
add public address
ab53476 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
update to add mnemomic to state
e180e0b 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@vercel
Copy link

vercel bot commented Mar 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
manta-signer ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 6:36PM (UTC)

@ferrell-code ferrell-code marked this pull request as draft March 6, 2023 16:00
@ferrell-code
load authorization context
40e5f57 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
add authorization context
e1cd1cb 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@SupremoUGH SupremoUGH mentioned this pull request Mar 6, 2023
Merged
8 tasks
@ferrell-code ferrell-code added C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Changelog: add these changes to the `changed` section of the changelog A-compatibility Area: Issues and PRs related to Compatibility labels Mar 7, 2023
@ferrell-code ferrell-code marked this pull request as ready for review March 7, 2023 01:15
@ferrell-code
update to main
9b82637 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
add to changelog
5704ac8 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
merge main
d82b69f 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
Use tag
36aea29 
Signed-off-by: Charles Ferrell <charlie@manta.network>
ghzlatarev
ghzlatarev reviewed Mar 7, 2023
View reviewed changes
Cargo.lock Show resolved Hide resolved
@ferrell-code
update Cargo.lock
c364af0 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
minimize Cargo.lock change
15c1084 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@Apokalip Apokalip merged commit 54590f5 into main Mar 8, 2023
@Apokalip Apokalip deleted the add-sinks-validation branch March 8, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apokalip Apokalip Apokalip approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@SupremoUGH SupremoUGH Awaiting requested review from SupremoUGH

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

@bhgomes bhgomes Awaiting requested review from bhgomes

@Kevingislason Kevingislason Awaiting requested review from Kevingislason

Assignees
No one assigned
Labels
A-compatibility Area: Issues and PRs related to Compatibility C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferrell-code @Apokalip @ghzlatarev