Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with frontend #4

Merged
merged 37 commits into from Sep 20, 2021
Merged

Integrate with frontend #4

merged 37 commits into from Sep 20, 2021

Conversation

Kevingislason
Copy link
Contributor

@Kevingislason Kevingislason commented Sep 17, 2021

This is the MVP version of Manta Signer. Manta Signer is a desktop application composed of a simple UI and a daemon running in the background. When Manta's web app needs to perform an operation requiring access to the root seed, it sends a request to Manta Signer's daemon.

Manta Signer has two purposes:

  1. Increase ZKP generation speed--native Rust is much faster than web assembly (for now at least)
  2. Protect Manta account secrets by keeping them out of the browser

When connected to a locally-running instance of Manta's web app, users are prompted to create an account on first login. Afterwards, the web app can use Manta Signer's daemon to generate addresses, mint private assets, reclaim private assets, and transfer private assets. Operations that spend private assets (reclaims and private transfers) prompt a Manta Signer popup requesting password entry.

-Reclaims and private transfers are temporarily broken pending Merkle tree changes.
-This only works on MacOS for now
-Need to revert back to the manta branch of manta-api once the ark-0.3 change is merged.

Copy link
Contributor

@stechu stechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general pending handling errors and a few nits.
Testing seems to be a big issue here. I think we perhaps want to log some known issues so that we can at least remember to fix them in the future.

README.md Outdated Show resolved Hide resolved
app.go Outdated Show resolved Hide resolved
lib/zkp/Cargo.toml Outdated Show resolved Hide resolved
lib/zkp/src/lib.rs Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
server.go Show resolved Hide resolved
@stechu
Copy link
Contributor

stechu commented Sep 18, 2021

PS: Please add a PR description as well.

@stechu
Copy link
Contributor

stechu commented Sep 18, 2021

One more thing, please remove the .a file from the PR. It should be generated from the build rather than commited.

@Kevingislason
Copy link
Contributor Author

@stechu Can you change the name of this repo to `manta-signer?

@stechu
Copy link
Contributor

stechu commented Sep 20, 2021

@stechu Can you change the name of this repo to `manta-signer?

Done, also manta-api changes have been merged.

@stechu stechu merged commit a8e2482 into master Sep 20, 2021
@bhgomes bhgomes deleted the integrate_with_frontend branch December 8, 2021 22:52
@bhgomes bhgomes added the L-added Changelog: add these changes to the `added` section of the changelog label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants