Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubuntu 18 #45

Merged
3 commits merged into from Jan 19, 2022
Merged

Add ubuntu 18 #45

3 commits merged into from Jan 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2022

Add Ubuntu 18.04 build, Hide about window on ready.

new build step for ubuntu 18.04, fixes issue with about window popping up on ubuntu machines.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Test following procedure in docs/testing-workflow.md
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • Update the version numbers properly:
    • Cargo.toml
    • ui/src-tauri/Cargo.toml
    • ui/src-tauri/tauri.conf.json
    • ui/public/about.html
    • ui/package.json

@ghost ghost marked this pull request as ready for review January 19, 2022 00:03
@ghost ghost requested review from bhgomes and Kevingislason January 19, 2022 00:06
@ghost ghost merged commit 2b0974c into master Jan 19, 2022
@ghost ghost deleted the add-ubuntu-18 branch January 19, 2022 16:28
@bhgomes bhgomes added the L-added Changelog: add these changes to the `added` section of the changelog label Jul 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants