[WIP] Moved JSON dictionary and array transformers to MTLJSONAdapter #258
Conversation
| // class must conform to <MTLJSONSerializing>. This argument must | ||
| // not be nil. | ||
| // | ||
| // Returns a reversible transformer which uses MTLJSONAdapter for transforming |
There was a problem hiding this comment.
This should point out that we always use the class of the receiver.
|
👍 nice! Can you add a test that verifies that if this is invoked on a subclass of |
|
Sure, though I'm not sure how best to test it. Is there a better way than checking serialization matches that expected for a given subclass? |
|
Hmm, not sure there is a nice way without adding mocks. I guess using a subclass with an implicit transformer is the easiest way. |
|
Sorry, just catching up—is this still a WIP? |
|
I'm afraid so. Just need to sort out a test but the implementation is done. On Thursday, 13 March 2014, Justin Spahr-Summers notifications@github.com
|
|
I believe it's still missing a test to verify the use of subclasses
|
|
🆒 No worries, just checking. |
|
Do you think we should add OCMock to verify this? I can't come up with a test that doesn't feel really hacky. |
|
I'd rather not. What's wrong with adding a subclass like MTLTestJSONAdapter? |
|
@dcaunt are still interested in working on this? |
|
Superseded by #474. |
Implements changes suggested in #203
Closes #203