Made automatic NSURL transfom to work even if JSONTransformerForKey method defined

[k06a]

This works nice:

@interface Video
@property (strong, nonatomic) NSURL *streamUrl;
@property (strong, nonatomic) Money *cost;
@end

@implementation Video
+ (NSValueTransformer *)costJSONTransformer {
    return [MTLValueTransformer transformerUsingForwardBlock:^id(id value, BOOL *success, NSError *__autoreleasing *error) {
        return [MTLJSONAdapter modelOfClass:[Money class] fromJSONDictionary:value error:nil];
    }];
}
@end

But this gives and NSURL transform error:

#import <libextobjc/extobjc.h>

@interface Video
@property (strong, nonatomic) NSURL *streamUrl;
@property (strong, nonatomic) Money *cost;
@end

@implementation Video
+ (NSValueTransformer *)JSONTransformerForKey:(NSString *)key {
    MTLValueTransformer *costTransformer = [MTLValueTransformer transformerUsingForwardBlock:^id(id value, BOOL *success, NSError *__autoreleasing *error) {
        return [MTLJSONAdapter modelOfClass:[Money class] fromJSONDictionary:value error:nil];
    }];

    return @{
        @keypath(Video.new, cost): costTransformer,
    }[key];
}
@end

Solution is to add this line:

@keypath(Video.new, streamUrl): [NSValueTransformer valueTransformerForName:MTLURLValueTransformerName],

But I really like automatic NSURL/BOOL transforming. Why it should not work when method JSONTransformerForKey: is defined?

[robb]

Thanks for the pull request, could you add some tests to that?

[robb]

This should use tabs for indentation.

[k06a]

@robb heh, I'm new to Quick and Nimble test frameworks. Is it possible to test without new class declaration?

[robb]

Probably not, but be have a bunch of small test classes already that should offer a good starting point.

[k06a]

@robb I've added test case, that fails on the old version and passes on the new :)

[robb]

Thanks ✌

[k06a]

@robb, do you have any plans about next (2.0.6 or 2.1.0) release date?
Can't wait to throw out a bunch of NSURL transformers from my projects :)

[robb]

@dcaunt as Release-Cutter in Chief, would you mind cutting a point-release? 🙇

[dcaunt]

I've released 2.0.7 to avoid any confusion about 2.0.6.

[robb]

@dcaunt Thanks a lot!