Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated file (service/index.ts) should be TypeScript strict mode complaint #23

Closed
callmeberzerker opened this issue May 22, 2019 · 4 comments
Closed

Generated file (service/index.ts) should be TypeScript strict mode complaint #23

callmeberzerker opened this issue May 22, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@callmeberzerker
Copy link
Contributor

No description provided.

@Manweill
Copy link
Owner

What problems are you currently experiencing?

@callmeberzerker
Copy link
Contributor Author

Basically the fields generated on the class are being set via a data object (which is any) and there is a key/string iteration to set the field values. TypeScript complains that there is no gurantee that all fields will be set.

The workaround is to set strict: false in tsconfig.json which opens another can of worms.

@Manweill
Copy link
Owner

@SpearThruster
Okey, I see.
And then, I will optimize it on the next version. can you set strict: false some days?
Or, you can push PR with it.

@Manweill Manweill added the enhancement New feature or request label May 22, 2019
@Manweill
Copy link
Owner

Manweill commented May 23, 2019 •
edited

Fixed in Ver 0.5.4

Manweill pushed a commit that referenced this issue May 23, 2019
#23 Support typescript strict mode
bcc5ecd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@callmeberzerker @Manweill