Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Provider should be configurable via env variables #7

Closed
syncush opened this issue Feb 2, 2021 · 0 comments
Closed

Trace Provider should be configurable via env variables #7

syncush opened this issue Feb 2, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@syncush
Copy link
Contributor

syncush commented Feb 2, 2021

As of today, the trace provider is configurable via function parameter, this behavior creates undesired changes in each service that would like to adopt the telemetry package, for example reading service name and version from package.json.

therefore we should no longer accept a config but be configurable via env and automatically infer the service name and version.

important note, we should export a NoopProvider for cases where services are running tests and would like to turn off the tracing and metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants