replace variable length arrays with std::vector #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| osmid_t all_parts[member_count]; | ||
| int all_count = 0; | ||
| keyval::initList( &member_list ); | ||
| for( i=0; i<member_count; i++ ) | ||
| { | ||
| char tag = 0; |
There was a problem hiding this comment.
Any idea what tag is for? Seems to be set but not used?
There was a problem hiding this comment.
It is used for some printing into buffer:
https://github.com/alex85k/osm2pgsql/blob/array-to-vector/middle-pgsql.cpp#L799
alex85k
force-pushed
the
array-to-vector
branch
from
1d87df6
to
aeff786
Compare
|
Repushed with reserve() calls. |
zerebubuth
added a commit
that referenced
this pull request
Oct 3, 2014
replace variable length arrays with std::vector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have prepared the most direct version of std::vector-instead-variable-c99-array, intentinally not changing the signatures. I hope you'll introduce vector parameters etc. in more consistent way than I can.
The final steps to support Windows is the described array change and osm2pgsql-dev@7d780c9 inclusion (done in master but not here).
Could you please run
make checkon Linux? On Windows I have 8 rounding errors, one UTF8 error and oneProjection code failed to initialize(will solve it by configuring environment).