Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default symbol changes - documentation #4435

Closed
havatv opened this issue Aug 27, 2012 · 8 comments
Closed

Default symbol changes - documentation #4435

havatv opened this issue Aug 27, 2012 · 8 comments
Assignees
Milestone

Comments

@havatv
Copy link

havatv commented Aug 27, 2012

There has been some questions on the mail lists recently that has to do with defaults for rendering. Here are some issues - I guess that they are documentation issues (but they may also be bugs).

I have tested AGG PNG and (Cairo) PDF output.

While documentation for STYLE-> SYMBOL seems to reflect current behaviour, the documentation for CLASS->SYMBOL says that:

Default is 0, which results in a single pixel, single width line, or solid
polygon fill, depending on layer type.

The documenation of STYLE and CLASS COLOR should be updated to state what the "default" is. Current Mapserver behaviour seems to be that if no colour is specified for STYLE or CLASS, nothing will be drawn for most of the symbol types except pixmap (I have tested vector, ellipse and truetype).

I am also wondering if the SYMBOL TYPE "simple" is still around. It seems to have been removed. I have tried to use it, and can't seem to make it work (I have testet with a point layer).

Before I start updating documentation, it would be good if someone could confirm that that these are documentation issues and not bugs.

@ghost ghost assigned havatv Aug 27, 2012
@tbonfort
Copy link
Member

@havatv ,

I would put class->style, class->color, class->size ,etc... as deprecated, as they are here for backwards compatibilty (they are translated into their STYLE equivalents). they should be moved into an explicit style block.

For style->color, it is correct that a style with no color will not be rendered apart for pixmap symbols (and SVG symbols also in 6.2)

type simple for symbols is unused, and is equivalent to setting no style->symbol. it can be marked as deprecated with a note that pattern, gap?, linecap, etc... have been moved to STYLE.

thanks,
thomas

@havatv
Copy link
Author

havatv commented Aug 27, 2012

OK. I will try to improve the documentation.
@tbonfort , would you like this to be done in the 6.0 branch?

@tbonfort
Copy link
Member

@havatv I'd say only 6.2, 6.0 will be put offline/archived pretty soon. thanks.

@havatv
Copy link
Author

havatv commented Aug 27, 2012

I did the commit, but did a cut and paste error with the issue number. Sorry about that. The commit is:
MapServer/MapServer-documentation@83093dc

In the commit, I also removed and deprecated a number of deprecated parameters / keywords, and did som other changes:

MAP: Removed SCALE

LAYER: Removed LABELMAXSCALE, LABELMINSCALE, MAXSCALE, MINSCALE, SYMBOLSCALE

SYMBOL: Removed GAP, LINECAP, LINEJOIN, LINEMAXJOINSIZE, PATTERN, STYLE, TYPE->simple. Included a note that line styling had been moved to CLASS->STYLE.

CLASS: Removed MAXSCALE, MINSCALE. Marked the following as deprecated: BACKGROUNDCOLOR, COLOR, MAXSIZE, MINSIZE, OUTLINECOLOR, SIZE, SYMBOL (these have all been moved to STYLE). Removed the comment at the bottom on stacked symbols.

STYLE: Removed SIZEITEM.

@havatv havatv closed this as completed Aug 27, 2012
@havatv
Copy link
Author

havatv commented Aug 27, 2012

@tbonfort and @sdlime , could you check if the documentation changes are OK. I don't have the full picture...

@sdlime
Copy link
Member

sdlime commented Aug 27, 2012

Is a compiled version (e.g. web page) some place for review or is it best to work with the diff? --Steve

@havatv
Copy link
Author

havatv commented Aug 28, 2012

@sdlime , it will be better to work with the diff. It is not that much, and I have tried to mention all the significant changes in the comment above).

@tbonfort
Copy link
Member

@havatv I'm fine with the changes. They are a bit radical but it's a good thing we're removing this legacy syntax from the main docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants