Double backslashes in Windows UNC pathnames should be escaped by the mapfile writer #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szekerest
added a commit
that referenced
this pull request
Sep 1, 2013
Double backslashes in Windows UNC pathnames should be escaped by the mapfile writer
ghost
assigned 
|
Looks like we require similar handling for the CONFIG section (writeHashTableInline). Some config options mas also contain filenames with backslashes which should also be escaped. |
szekerest
added a commit
to szekerest/mapserver
that referenced
this pull request
Jan 28, 2014
szekerest
added a commit
that referenced
this pull request
Jan 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the mapserver parser changes the double backslashes to a single slash the reverse operation should take place when writing the mapfile. Currently if we do subsequent load and write operations on the same mapfile we may get invalid file locatons in the mapfiles.
For exampe if we have "\myserver\myshare\Maps\myfile.shp" in the DATA section loading and then saving the file will results: "\myserver\myshare\Maps\myfile.shp". When loading the map back again we will get "\myserver\myshare\Maps\myfile.shp" which is an invalid file location causing run time issues.
I think backslashes should be replaced with double backslashes every time when saving the file at least in the CONNECTION, DATA, SHAPEPATH, FONTSET, SYMBOLSET sections.