Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor custom events name dispatched by mapml-viewer #869

Open
AliyanH opened this issue Jul 5, 2023 · 1 comment · May be fixed by #872
Open

Refactor custom events name dispatched by mapml-viewer #869

AliyanH opened this issue Jul 5, 2023 · 1 comment · May be fixed by #872
Assignees
Milestone

Comments

@AliyanH
Copy link
Member

AliyanH commented Jul 5, 2023

refactor custom events dispatched by mapml-viewer so they don't clash with leaflet events, ex. "zoomend" -> "map-zoomend".
All events - https://maps4html.org/web-map-doc/docs/api/mapml-viewer-api#events
https://github.com/Maps4HTML/Web-Map-Custom-Element/blob/94fa0896a87504777bb58c808e0b5f805926b2cf/src/mapml-viewer.js#L619-L852

@prushforth
Copy link
Member

See also

@AliyanH AliyanH self-assigned this Jul 11, 2023
@AliyanH AliyanH linked a pull request Jul 11, 2023 that will close this issue
@prushforth prushforth added this to the Autumn 2023 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants